amygbAI commented on PR #20: URL: https://github.com/apache/incubator-graphar-testing/pull/20#issuecomment-2159775221
changed and pushed but isn't this generated because of this line in the script run-ldbc-sample2graphar.sh ? output_dir="/tmp/graphar/ldbc_sample/" should we just change it to "" in the incubator-graph repo ? On Tue, Jun 11, 2024 at 9:34 AM Weibin Zeng ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In ldbc_sample/json/LdbcSample.graph.yml > <https://github.com/apache/incubator-graphar-testing/pull/20#discussion_r1634143354> > : > > > @@ -0,0 +1,7 @@ > +vertices: > + - Person.vertex.yml > +prefix: /tmp/graphar/ldbc_sample/ > > It's better not set the prefix of the graph.yml (default is the relative > path of the graph yaml) since the test data may not download to the the > /tmp/graphar/ldbc_sample/ > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-graphar-testing/pull/20#pullrequestreview-2109248810>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATIQOSHEH4RWNZR533ZGWCLZGZZNXAVCNFSM6AAAAABJDMXJJSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBZGI2DQOBRGA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
