SemyonSinchenko commented on code in PR #521: URL: https://github.com/apache/incubator-graphar/pull/521#discussion_r1638376218
########## format/README.md: ########## @@ -0,0 +1,18 @@ +# GraphAr Format Specification + +This folder contains protocol definitions for the GraphAr format. + +## How to generate code + +### Prerequisites + +- [protoc](https://developers.google.com/protocol-buffers/docs/downloads) +- [buf](https://buf.build/docs/installation) Review Comment: It is important that we need to use buf >= 1.32 because we are on v2. May we mention it here? ########## format/README.md: ########## @@ -0,0 +1,18 @@ +# GraphAr Format Specification + +This folder contains protocol definitions for the GraphAr format. + +## How to generate code + +### Prerequisites + +- [protoc](https://developers.google.com/protocol-buffers/docs/downloads) +- [buf](https://buf.build/docs/installation) + +### Build + +```sh +buf generate Review Comment: It may be little confusing because one needs to run this command from the root of the project, not from the `format` folder ########## format/test_vertex_info.cc: ########## @@ -0,0 +1,57 @@ +/* Review Comment: What is the reason of that file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
