lixueclaire commented on PR #533: URL: https://github.com/apache/incubator-graphar/pull/533#issuecomment-2216328018
> Hi, @lixueclaire, I create this PR to consolidate all code into a single src directory and brings some `BREAKING CHANGE`, may need your opinion about the changes, especially the naming of the directory and file: > > * I use `high-level` for our high level reader and writer directory name > * Since we use `arrow` folder to separate the arrow reader and writer, so I change the `arrow_chunk_reader` and `arrow_chunk_writer` to `chunk_reader` and `chunk_writer`. > * And also the `api` 's header names. Hi, I think the APIs maybe a little confusing now. Originally, we have `chunk_info_reader` and `arrow_chunk_reader` and high-level graph collections. If we use `basic_reader`, it is not clear what is read. I suggest naming `info_reader/meta_reader`,`arrow_reader/chunk_reader` and `high_level_reader/graph_reader`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
