yecol commented on PR #558: URL: https://github.com/apache/incubator-graphar/pull/558#issuecomment-2255473496
> > <img alt="Screenshot 2024-07-29 at 14 25 29" width="1224" src="https://private-user-images.githubusercontent.com/426463/352936044-23f8be8b-0194-4084-9afc-fb44dbfe9b7e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNDYyOTAsIm5iZiI6MTcyMjI0NTk5MCwicGF0aCI6Ii80MjY0NjMvMzUyOTM2MDQ0LTIzZjhiZThiLTAxOTQtNDA4NC05YWZjLWZiNDRkYmZlOWI3ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOVQwOTM5NTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ODg1MTg2NDJmOGQ3MDkxOTNjYjEwYjQwYzhmMWI2YzFjYjRlZjgyM2MzOWY0NDc5N2Y2YzgyYjdmNDgwZDY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.I8ek-kiyRv93YqVe3zjwSyaGnXIlyxTGarSm5dcV7bk";> > > It is a little weird since I already guarded this code block. Please approve the CI to check this again. > > I konw it. the `ARROW_ORC` is just avariable in CMakeList, it can not be used as a macro definition, you need to define a macro definition after WARNING by `add_definitions(-DARROW_ORC)` Still strange. In the same file, it goes ARROW_ORC code-path in line-240 and NOT defined ARROW_ORC code-path in line-21, in the same file. However, to avoid this inconsistency, I have added the definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/426463/352936044-23f8be8b-0194-4084-9afc-fb44dbfe9b7e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNDYyOTAsIm5iZiI6MTcyMjI0NTk5MCwicGF0aCI6Ii80MjY0NjMvMzUyOTM2MDQ0LTIzZjhiZThiLTAxOTQtNDA4NC05YWZjLWZiNDRkYmZlOWI3ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOVQwOTM5NTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ODg1MTg2NDJmOGQ3MDkxOTNjYjEwYjQwYzhmMWI2YzFjYjRlZjgyM2MzOWY0NDc5N2Y2YzgyYjdmNDgwZDY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.I8ek-kiyRv93YqVe3zjwSyaGnXIlyxTGarSm5dcV7bk"](https://private-user-images.githubusercontent.com/426463/352936044-23f8be8b-0194-4084-9afc-fb44dbfe9b7e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNDYyOTAsIm5iZiI6MTcyMjI0NTk5MCwicGF0aCI6Ii80MjY0NjMvMzUyOTM2MDQ0LTIzZjhiZThiLTAxOTQtNDA4NC05YWZjLWZiNDRkYmZlOWI3ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOVQwOTM5NTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ODg1MTg2NDJmOGQ3MDkxOTNjYjEwYjQwYzhmMWI2YzFjYjRlZjgyM2MzOWY0NDc5N2Y2YzgyYjdmNDgwZDY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.I8ek-kiyRv93YqVe3zjwSyaGnXIlyxTGarSm5dcV7bk"){kind=link}