acezen commented on code in PR #625:
URL: https://github.com/apache/incubator-graphar/pull/625#discussion_r1752135938
##########
cpp/cmake/apache-arrow.cmake:
##########
@@ -108,16 +108,19 @@ function(build_arrow)
find_package(Threads)
find_package(Arrow QUIET)
- set(ARROW_VERSION_TO_BUILD "15.0.0" CACHE INTERNAL "arrow version")
- if (Arrow_FOUND) # arrow is installed, build the same version as the
installed one
- message(STATUS "Found Arrow installed, align to version:
${Arrow_VERSION}")
- set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow
version")
- endif ()
- set(GAR_ARROW_SOURCE_FILE
"https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz";)
+ set(ARROW_VERSION_TO_BUILD "13.0.0" CACHE INTERNAL "arrow version")
+ # if (Arrow_FOUND) # arrow is installed, build the same version as the
installed one
+ # set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow
version")
+ # endif ()
+ if(DEFINED ENV{GAR_ARROW_SOURCE_URL})
+ set(GAR_ARROW_SOURCE_URL "$ENV{GAR_ARROW_SOURCE_URL}")
+ else()
+ set(GAR_ARROW_SOURCE_URL
"https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz";)
+ endif()
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
