Elssky commented on code in PR #607: URL: https://github.com/apache/incubator-graphar/pull/607#discussion_r1772696311
########## cpp/src/graphar/arrow/chunk_reader.cc: ########## @@ -51,6 +51,18 @@ Result<std::shared_ptr<arrow::Schema>> PropertyGroupToSchema( return arrow::schema(fields); } +Result<std::shared_ptr<arrow::Schema>> LabelToSchema( Review Comment: This method is intended to be used when the VertexPropertyArrowChunkReader is initializing the`schema`, see Line 164 ########## cpp/src/graphar/arrow/chunk_reader.cc: ########## @@ -51,6 +51,18 @@ Result<std::shared_ptr<arrow::Schema>> PropertyGroupToSchema( return arrow::schema(fields); } +Result<std::shared_ptr<arrow::Schema>> LabelToSchema( Review Comment: This method is intended to be used when the VertexPropertyArrowChunkReader is initializing the`schema_`, see Line 164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
