Elssky commented on code in PR #634:
URL: https://github.com/apache/incubator-graphar/pull/634#discussion_r1816181696
##########
cpp/src/graphar/filesystem.cc:
##########
@@ -233,8 +233,13 @@ Status FileSystem::WriteTableToFile(const
std::shared_ptr<arrow::Table>& table,
break;
}
case FileType::PARQUET: {
+ auto schema = table->schema();
+ auto column_num = schema->num_fields();
parquet::WriterProperties::Builder builder;
builder.compression(arrow::Compression::type::ZSTD); // enable compression
+ for (int i = 0; i < column_num; ++i) {
Review Comment:
for sure!
##########
cpp/src/graphar/general_params.h:
##########
@@ -27,6 +27,7 @@ struct GeneralParams {
static constexpr const char* kDstIndexCol = "_graphArDstIndex";
static constexpr const char* kOffsetCol = "_graphArOffset";
static constexpr const char* kPrimaryCol = "_graphArPrimary";
+ static constexpr const char* kLabelCol = ":LABEL";
Review Comment:
yes, use ":LABEL" because we want to keep the column names consistent with
the csv, but of course we can change the name in the arrow table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
