yangxk1 commented on issue #676: URL: https://github.com/apache/incubator-graphar/issues/676#issuecomment-2893375821
While writing unit tests, I found three issues: 1. Extra `/` in path concatenation(e.g. `"vertex/person//id/"`) (minor). 2. Missing `getVersion()` in GraphInfo, VertexInfo, and EdgeInfo (may affect usage). 3. Parameter order mismatch in EdgeInfo constructor vs. EdgeYaml#toEdgeInfo (**this can lead to serious bugs**). Specifically, In the constructor of EdgeInfo, the parameter srcChunkSize appears before chunkSize. However, in org.apache.graphar.info.yaml.EdgeYaml#toEdgeInfo, srcChunkSize is passed after chunkSize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
