Re: [PR] fix(java,info): Reorder parameters in EdgeInfo constructor [incubator-graphar]

[via GitHub]

yecol commented on PR #685:
URL: 
https://github.com/apache/incubator-graphar/pull/685#issuecomment-2910946384

   > Thanks for your suggestion @Thespica ! But looking at the C++ constructor 
for 
[EdgeInfo](https://github.com/apache/incubator-graphar/blob/main/cpp/src/graphar/graph_info.cc),
 the order is `edgeChunkSize` → `srcChunkSize` → `dstChunkSize`. I think 
keeping the same order in Java would be more intuitive and user-friendly. 
![edge_info](https://private-user-images.githubusercontent.com/81174897/447340902-ece9662a-425a-498f-9219-9740d126c6a7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDgzMTM5MjcsIm5iZiI6MTc0ODMxMzYyNywicGF0aCI6Ii84MTE3NDg5Ny80NDczNDA5MDItZWNlOTY2MmEtNDI1YS00OThmLTkyMTktOTc0MGQxMjZjNmE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTI3VDAyNDAyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBlZWQ5NTk0YThhYWZmZmIzMGRkN2JiYmVkYWYwYmZk
 
ZTQ1YTY2YWQ3NGZmNWNjZWNmZWZmMTZkMDFkMmFlY2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-uNgnCyMmtq4s-bvdAWWv1t6UpQsaDLH11yg0Ibwdu4)
   
   I agree to keep them consistent. 
   However, I also agree that src-edge-dst would be better for understanding. 
Let's open another issue to modify C++ and Java both if in need. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org