Thespica commented on code in PR #705:
URL: https://github.com/apache/incubator-graphar/pull/705#discussion_r2173172088
##########
maven-projects/java/src/main/java/org/apache/graphar/util/Result.java:
##########
@@ -19,27 +19,7 @@
package org.apache.graphar.util;
-import static
org.apache.graphar.util.CppClassName.GAR_ADJ_LIST_ARROW_CHUNK_READER;
-import static
org.apache.graphar.util.CppClassName.GAR_ADJ_LIST_CHUNK_INFO_READER;
-import static
org.apache.graphar.util.CppClassName.GAR_ADJ_LIST_OFFSET_ARROW_CHUNK_READER;
-import static
org.apache.graphar.util.CppClassName.GAR_ADJ_LIST_PROPERTY_ARROW_CHUNK_READER;
-import static
org.apache.graphar.util.CppClassName.GAR_ADJ_LIST_PROPERTY_CHUNK_INFO_READER;
-import static org.apache.graphar.util.CppClassName.GAR_DATA_TYPE;
-import static org.apache.graphar.util.CppClassName.GAR_EDGES_COLLECTION;
-import static org.apache.graphar.util.CppClassName.GAR_EDGE_INFO;
-import static org.apache.graphar.util.CppClassName.GAR_FILE_TYPE;
-import static org.apache.graphar.util.CppClassName.GAR_GRAPH_INFO;
-import static org.apache.graphar.util.CppClassName.GAR_ID_TYPE;
-import static org.apache.graphar.util.CppClassName.GAR_INFO_VERSION;
-import static org.apache.graphar.util.CppClassName.GAR_PROPERTY_GROUP;
-import static org.apache.graphar.util.CppClassName.GAR_RESULT;
-import static org.apache.graphar.util.CppClassName.GAR_VERTEX_INFO;
-import static
org.apache.graphar.util.CppClassName.GAR_VERTEX_PROPERTY_ARROW_CHUNK_READER;
-import static
org.apache.graphar.util.CppClassName.GAR_VERTEX_PROPERTY_CHUNK_INFO_READER;
-import static org.apache.graphar.util.CppClassName.GAR_VERTICES_COLLECTION;
-import static org.apache.graphar.util.CppClassName.STD_PAIR;
-import static org.apache.graphar.util.CppClassName.STD_SHARED_PTR;
-import static org.apache.graphar.util.CppClassName.STD_STRING;
+import static org.apache.graphar.util.CppClassName.*;
Review Comment:
do it too
##########
maven-projects/java/src/main/java/org/apache/graphar/stdcxx/StdPair.java:
##########
@@ -35,7 +35,7 @@
@CXXHead(system = "utility")
@CXXHead(GAR_GRAPH_H)
@CXXTemplate(
- cxx = {"GraphArchive::IdType", "GraphArchive::IdType"},
+ cxx = {"graphar::IdType", "graphar::IdType"},
Review Comment:
1. The namespace should be `graphar` or `GraphArchive`? pleas make it align.
2. the type name of graphar-cpp were recoded as const in
[here](https://github.com/apache/incubator-graphar/blob/main/maven-projects/java/src/main/java/org/apache/graphar/util/CppClassName.java#L46)
##########
maven-projects/java/src/main/java/org/apache/graphar/util/InfoVersion.java:
##########
@@ -20,33 +20,17 @@
package org.apache.graphar.util;
import static org.apache.graphar.util.CppClassName.GAR_INFO_VERSION;
-import static org.apache.graphar.util.CppHeaderName.GAR_GRAPH_INFO_H;
+import static org.apache.graphar.util.CppHeaderName.GAR_VERSION_PARSER_H;
-import com.alibaba.fastffi.CXXHead;
-import com.alibaba.fastffi.CXXOperator;
-import com.alibaba.fastffi.CXXPointer;
-import com.alibaba.fastffi.CXXReference;
-import com.alibaba.fastffi.CXXValue;
-import com.alibaba.fastffi.FFIFactory;
-import com.alibaba.fastffi.FFIGen;
-import com.alibaba.fastffi.FFINameAlias;
-import com.alibaba.fastffi.FFITypeAlias;
-import com.alibaba.fastffi.FFITypeFactory;
+import com.alibaba.fastffi.*;
Review Comment:
do it too
##########
maven-projects/java/src/main/java/org/apache/graphar/graphinfo/Property.java:
##########
@@ -22,16 +22,8 @@
import static org.apache.graphar.util.CppClassName.GAR_PROPERTY;
import static org.apache.graphar.util.CppHeaderName.GAR_GRAPH_INFO_H;
-import com.alibaba.fastffi.CXXHead;
-import com.alibaba.fastffi.CXXPointer;
-import com.alibaba.fastffi.CXXValue;
-import com.alibaba.fastffi.FFIFactory;
-import com.alibaba.fastffi.FFIGen;
-import com.alibaba.fastffi.FFIGetter;
-import com.alibaba.fastffi.FFINameAlias;
-import com.alibaba.fastffi.FFISetter;
-import com.alibaba.fastffi.FFITypeAlias;
-import com.alibaba.fastffi.FFITypeFactory;
+import com.alibaba.fastffi.*;
Review Comment:
do it too
##########
maven-projects/java/src/main/java/org/apache/graphar/graphinfo/EdgeInfo.java:
##########
@@ -23,22 +23,12 @@
import static org.apache.graphar.util.CppClassName.GAR_ID_TYPE;
import static org.apache.graphar.util.CppHeaderName.GAR_GRAPH_INFO_H;
-import com.alibaba.fastffi.CXXHead;
-import com.alibaba.fastffi.CXXPointer;
-import com.alibaba.fastffi.CXXReference;
-import com.alibaba.fastffi.CXXValue;
-import com.alibaba.fastffi.FFIFactory;
-import com.alibaba.fastffi.FFIGen;
-import com.alibaba.fastffi.FFILibrary;
-import com.alibaba.fastffi.FFINameAlias;
-import com.alibaba.fastffi.FFITypeAlias;
-import com.alibaba.fastffi.FFITypeFactory;
+import com.alibaba.fastffi.*;
Review Comment:
Do it too
##########
maven-projects/java/src/main/java/org/apache/graphar/util/GrapharStaticFunctions.java:
##########
@@ -21,21 +21,11 @@
import static org.apache.graphar.util.CppClassName.GAR_ID_TYPE;
import static org.apache.graphar.util.CppClassName.GAR_NAMESPACE;
-import static org.apache.graphar.util.CppHeaderName.GAR_ARROW_CHUNK_READER_H;
-import static org.apache.graphar.util.CppHeaderName.GAR_CHUNK_INFO_READER_H;
-import static org.apache.graphar.util.CppHeaderName.GAR_GRAPH_H;
-
-import com.alibaba.fastffi.CXXHead;
-import com.alibaba.fastffi.CXXReference;
-import com.alibaba.fastffi.CXXValue;
-import com.alibaba.fastffi.FFIGen;
-import com.alibaba.fastffi.FFILibrary;
-import com.alibaba.fastffi.FFINameAlias;
-import com.alibaba.fastffi.FFITypeAlias;
-import com.alibaba.fastffi.FFITypeFactory;
+import static org.apache.graphar.util.CppHeaderName.*;
+
+import com.alibaba.fastffi.*;
import org.apache.graphar.edges.EdgesCollection;
-import org.apache.graphar.graphinfo.GraphInfo;
-import org.apache.graphar.graphinfo.PropertyGroup;
+import org.apache.graphar.graphinfo.*;
Review Comment:
do it too
##########
maven-projects/java/src/main/java/org/apache/graphar/stdcxx/StdSharedPtr.java:
##########
@@ -19,9 +19,7 @@
package org.apache.graphar.stdcxx;
-import static org.apache.graphar.util.CppClassName.ARROW_ARRAY;
-import static org.apache.graphar.util.CppClassName.ARROW_TABLE;
-import static org.apache.graphar.util.CppClassName.GAR_UTIL_INDEX_CONVERTER;
+import static org.apache.graphar.util.CppClassName.*;
Review Comment:
do it too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
