yangxk1 commented on PR #712: URL: https://github.com/apache/incubator-graphar/pull/712#issuecomment-3017694134
Very good! Thanks for the PR! some small suggestions: - [ ] Could getVersion() return InfoVersion directly? - [ ] I think it would make sense to move InfoVersion out of VersionParser, as it's part of the public API, but VersionParser is more of a tool class. - [ ] Please add some unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
