yangxk1 commented on code in PR #714: URL: https://github.com/apache/incubator-graphar/pull/714#discussion_r2174282131
########## maven-projects/info/src/main/java/org/apache/graphar/info/ChunkInfoReader.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.graphar.info; + +public class ChunkInfoReader { + private final VertexInfo cachedVertexInfo; + private final PropertyGroup cachedPropertyGroup; + + public long chunkExists(long internalId) { + chunkIdx = internalId / cachedVertexInfo.getChunkSize(); + chunkCount = FileReader.getFileCount(cachedVertexInfo, cachedPropertyGroup); + if (chunkIdx < chunkCount) { + return true; + } + return false; + } + + public String getPropertyGroupChunkPath(PropertyGroup propertyGroup, long chunkIndex) { Review Comment: Why move from `VertexInfo.java` to here ########## maven-projects/info/src/main/java/org/apache/graphar/info/FileReader.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.graphar.info; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; + +import java.io.BufferedReader; +import java.io.InputStreamReader; +import java.io.IOException; +import java.net.URI; + +public static class FileReader { + + //TODO API to read data files based on type (CSV, Parquet, ..) + public static long getFileCount(VertexInfo vertexInfo,PropertyGroup propertyGroup) { + // TODO check equality test for type + String type = propertyGroup.getFileType().toString(); + numberOfParts = vertexInfo.getChunkSize() + chunkBasePath = vertexInfo.getPropertyGroupPrefix() + "/part"; Review Comment: Is "part" or "chunk"? Please confirm. ########## maven-projects/info/src/main/java/org/apache/graphar/info/FileReader.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.graphar.info; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; + +import java.io.BufferedReader; +import java.io.InputStreamReader; +import java.io.IOException; +import java.net.URI; + +public static class FileReader { + + //TODO API to read data files based on type (CSV, Parquet, ..) + public static long getFileCount(VertexInfo vertexInfo,PropertyGroup propertyGroup) { + // TODO check equality test for type + String type = propertyGroup.getFileType().toString(); + numberOfParts = vertexInfo.getChunkSize() + chunkBasePath = vertexInfo.getPropertyGroupPrefix() + "/part"; + totalRowCount = 0; + + for (int i : numberOfParts) { + chunkPath = chunkBasePath + Integer.toString(i); + if (type == "CSV") { Review Comment: It's better to use [FileType](https://github.com/apache/incubator-graphar/blob/main/format/enums.proto) instead of String -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
