yangxk1 commented on PR #713: URL: https://github.com/apache/incubator-graphar/pull/713#issuecomment-3021582909
> > Thanks for the PR — the `version` support you added is really useful! > > I just wanted to clarify one thing: I think my earlier explanation wasn't very clear. "property filtering", I meant filtering properties during data reading using predicate pushdown, e.g., reading only certain properties from Parquet/CSV/ORC files. > > some small suggestions: > > > > * Could `getVersion()` return `InfoVersion` directly? > > * I think it would make sense to move `InfoVersion` out of `VersionParser`, as it's part of the public API, but `VersionParser` is more of a tool class. > > getVersion() are you talking about graph version or vertex version or both ? I changed the code to getVersion for both, assuming it is the same. > > Wil lhave to rename this PR to graph_vertex_version_info though Also impl in edgeInfo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
