yangxk1 commented on code in PR #713:
URL: https://github.com/apache/incubator-graphar/pull/713#discussion_r2253623572
##########
maven-projects/info/src/main/java/org/apache/graphar/info/GraphInfo.java:
##########
@@ -183,6 +183,12 @@ public String getPrefix() {
return protoGraphInfo.getPrefix();
}
+ // TODO test protoGraphInfo why is not returning the version from the
graph yaml file?
+ public VersionInfo getVersion() {
+ return VersionParser.getVersion(
Review Comment:
should not set `gar/v1` as the default version. In c++ library if version
does not exist in yaml, the version will be set to `nullptr` (as NULL in JAVA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
