yangxk1 commented on code in PR #769:
URL: https://github.com/apache/incubator-graphar/pull/769#discussion_r2359826711
##########
maven-projects/info/src/main/java/org/apache/graphar/info/PropertyGroup.java:
##########
@@ -192,26 +235,17 @@ List<PropertyGroup> getPropertyGroupList() {
return propertyGroupList;
}
- Map<String, PropertyGroup> getPropertyGroupMap() {
- return propertyGroupMap;
- }
-
PropertyGroup getPropertyGroup(String propertyName) {
checkPropertyExist(propertyName);
return propertyGroupMap.get(propertyName);
}
- Map<String, Property> getProperties() {
- return properties;
- }
-
private void checkPropertyExist(String propertyName) {
if (null == propertyName) {
throw new IllegalArgumentException("Property name is null");
}
if (!hasProperty(propertyName)) {
- throw new IllegalArgumentException(
- "Property " + propertyName + " does not exist in the
property group " + this);
+ throw new IllegalArgumentException("Property " + propertyName + "
does not exist");
Review Comment:
PropertyGroup doesnot have toString() method, There is no point in adding
this to the exception log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
