Jarvx200 commented on PR #764: URL: https://github.com/apache/incubator-graphar/pull/764#issuecomment-3394412800
Hello, sorry for the delay, I simplified the solution with the cost of some duplicated code and also added tests for the PropertyGroup builder methods. I propose it he coverage is ok and it can be merged to have a further discussion about what type of abstraction would be beneficial to respect dry principles but also to not decrease readability (as @yangxk1 mentioned). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
