Sober7135 opened a new issue, #789: URL: https://github.com/apache/incubator-graphar/issues/789
### Describe the enhancement requested The test is "read multi-properties from csv file". # Cause The failure is caused by side effect inside `assert` statement. In Release/RelWithDebInfo builds, the code inside it is not executed. https://github.com/apache/incubator-graphar/blob/a88cd01f610d534a42418bf25931f9bda3d9391c/cpp/test/test_multi_property.cc#L145 I think we should avoid placing state-changing logic inside `assert`. Maybe we should use `ASSERT`/`REQUIRE` instead of `assert`. # Step to Reproduce 1. `cd cpp` 2. `cmake -B build -S . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_TESTS=ON` 3. `cmake --build build -- -j` 4. `cd build` 5. `GAR_TEST_DATA=${PWD}/../../testing ctest` # Log ``` Test project /workspace/cpp/build Start 1: InfoVersion 1/20 Test #1: InfoVersion ............................ Passed 0.01 sec Start 2: Property 2/20 Test #2: Property ............................... Passed 0.01 sec Start 3: PropertyGroup 3/20 Test #3: PropertyGroup .......................... Passed 0.01 sec Start 4: AdjacentList 4/20 Test #4: AdjacentList ........................... Passed 0.01 sec Start 5: VertexInfo 5/20 Test #5: VertexInfo ............................. Passed 0.01 sec Start 6: EdgeInfo 6/20 Test #6: EdgeInfo ............................... Passed 0.01 sec Start 7: GraphInfo 7/20 Test #7: GraphInfo .............................. Passed 0.01 sec Start 8: LoadFromYaml 8/20 Test #8: LoadFromYaml ........................... Passed 0.01 sec Start 9: TestVertexPropertyWriter 9/20 Test #9: TestVertexPropertyWriter ............... Passed 0.05 sec Start 10: TestEdgeChunkWriter 10/20 Test #10: TestEdgeChunkWriter .................... Passed 0.02 sec Start 11: Test_vertices_builder 11/20 Test #11: Test_vertices_builder .................. Passed 0.02 sec Start 12: test_edges_builder 12/20 Test #12: test_edges_builder ..................... Passed 0.02 sec Start 13: ChunkInfoReader 13/20 Test #13: ChunkInfoReader ........................ Passed 0.01 sec Start 14: ArrowChunkReader 14/20 Test #14: ArrowChunkReader ....................... Passed 0.04 sec Start 15: EmptyChunkTest 15/20 Test #15: EmptyChunkTest ......................... Passed 0.01 sec Start 16: JSON_TEST 16/20 Test #16: JSON_TEST .............................. Passed 0.02 sec Start 17: Graph 17/20 Test #17: Graph .................................. Passed 0.12 sec Start 18: test_multi_label_builder 18/20 Test #18: test_multi_label_builder ............... Passed 0.02 sec Start 19: read multi-properties from csv file 19/20 Test #19: read multi-properties from csv file ....Subprocess aborted***Exception: 0.02 sec Start 20: TestMultiProperty high level builder 20/20 Test #20: TestMultiProperty high level builder ... Passed 0.01 sec 95% tests passed, 1 tests failed out of 20 Total Test time (real) = 0.44 sec The following tests FAILED: 19 - read multi-properties from csv file (Subprocess aborted) Errors while running CTest Output from these tests are in: /workspace/cpp/build/Testing/Temporary/LastTest.log Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely. ``` I’m willing to submit a PR for this. ### Component(s) C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
