Sober7135 commented on issue #809: URL: https://github.com/apache/incubator-graphar/issues/809#issuecomment-3657028221
> Thank you very much for your interest in it! I think it should be completely replaced. I also want to get your opinion [@Sober7135](https://github.com/Sober7135) I'm just sharing my opinion on scope: * I think "completely replaced" is: replace `int` **where it participates in a binary/layout contract** (on-disk / IPC / serialization, and any public API-facing structs/enums where a fixed 32/64-bit width is intended). It doesn’t need to mean replacing every local `int` inside function bodies. * Also please don’t forget enums. For example, change this to `enum class Type : int32_t` / `uint32_t` [https://github.com/apache/incubator-graphar/blob/bb4a1d335c9f8f50a534ccf08432b101aa493ae9/cpp/src/graphar/types.h#L39-L41](https://github.com/apache/incubator-graphar/blob/bb4a1d335c9f8f50a534ccf08432b101aa493ae9/cpp/src/graphar/types.h#L39-L41) * On `size_t`: it’s fine for in-memory sizes / public APIs / FFI (Rust side usually maps to `usize`), but it should not appear in on-disk / IPC / serialization layouts since its width is platform-dependent. CC @yangxk1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
