yangxk1 commented on issue #810: URL: https://github.com/apache/incubator-graphar/issues/810#issuecomment-3695603035
Hi @tanmoyPaul12 , thanks for claiming this! While working on the CMake configuration, could you please consider the following linking strategy to ensure the distribution is robust? 1. Hybrid Linking: - Dependencies built from source (bundled) should ideally be statically linked (e.g., by forcing BUILD_SHARED_LIBS=OFF for those targets). This keeps the installation self-contained. - System dependencies can remain dynamic (or whatever the system provides). 2. RPATH Configuration: - For dynamic linking, please ensure CMAKE_INSTALL_RPATH is correctly set (e.g., using $ORIGIN on Linux) so that users don't need to manually configure LD_LIBRARY_PATH to run the installed library. The following is the ideal rendering proposed by @Sober7135 <img width="775" height="421" alt="Image" src="https://github.com/user-attachments/assets/750c9a28-dbb2-434f-aec1-4bf747b0440f"; /> I also wrote a draft, hope it helps. https://github.com/yangxk1/incubator-graphar/blob/810-improve-cmakelist-library-distribution/cpp/CMakeLists.txt cc @Sober7135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
