tanmoyPaul12 opened a new pull request, #819: URL: https://github.com/apache/incubator-graphar/pull/819
<!-- Thanks for contributing to GraphAr. If this is your first pull request you can find detailed information on [CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md) The Apache GraphAr (incubating) community has restrictions on the naming of pr title. You can find instructions in [CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md#title) too. --> Fixes #810 ### Reason for this PR The current CMake installation logic in GraphAr does not reliably support library distribution and downstream consumption, especially on Windows. This PR addresses the CMake install and export issues discussed in #810 and makes runtime installation behavior consistent across platforms. ### What changes are included in this PR? - Remove duplicate and conflicting install logic for the `graphar` target - Define a single canonical `install(TARGETS graphar ...)` rule - Ensure headers and CMake package config files are installed correctly - Fix Windows runtime (DLL) installation issues during `cmake --install` - Validate installation with MSVC + vcpkg + Apache Arrow ### Are these changes tested? - Windows 11 - MSVC (Visual Studio 2026) - CMake + vcpkg - Apache Arrow installed via vcpkg (arrow[dataset,parquet]) - Verified: - `cmake --build . --config Release` - `cmake --install . --config Release` - Generated headers and CMake config files ### Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. This change affects CMake install and packaging behavior only and does not modify GraphAr APIs or runtime behavior. <!-- If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking. --> <!-- **BREAKING CHANGE: <description>** --> <!-- Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious. --> <!-- **Critical Fix: <description>** --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
