Sober7135 commented on code in PR #823: URL: https://github.com/apache/incubator-graphar/pull/823#discussion_r2672057924
########## cpp/CMakeLists.txt: ########## Review Comment: 1. `-O0 -g -fno-omit-frame-pointer` is added twice. The actual flag in debug mode with `GRAPHAR_ENABLE_SANITIZER=OFF` is `-g -O0 -g -fno-omit-frame-pointer -fsanitize=address -O0 -g -fno-omit-frame-pointer -fsanitize=address` 2. and we should remove address sanitizer when `GRAPHAR_ENABLE` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
