Copilot commented on code in PR #849:
URL: https://github.com/apache/incubator-graphar/pull/849#discussion_r2786202158
##########
cpp/thirdparty/mini-yaml/yaml/Yaml.cpp:
##########
@@ -1375,7 +1375,7 @@ namespace Yaml
//Print();
ParseRoot(root);
}
- catch(Exception e)
+ catch(const Exception& e)
Review Comment:
The caught exception variable `e` is unused in this handler; with
`-Wunused-variable` this can still trigger a warning. Consider removing the
name (`catch (const Exception&)`) or using `e` (e.g., for logging) to fully
eliminate the warning.
```suggestion
catch(const Exception&)
```
##########
cpp/thirdparty/mini-yaml/yaml/Yaml.cpp:
##########
@@ -2250,7 +2250,7 @@ namespace Yaml
pImp->Parse(root, stream);
delete pImp;
}
- catch (const Exception e)
+ catch (const Exception& e)
Review Comment:
The caught exception variable `e` is unused in this handler; with
`-Wunused-variable` this can still trigger a warning. Consider changing to an
unnamed catch (`catch (const Exception&)`) or otherwise using `e` so the PR
fully addresses the warning category it targets.
```suggestion
catch (const Exception&)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
