Copilot commented on code in PR #854:
URL: https://github.com/apache/incubator-graphar/pull/854#discussion_r2806815994
##########
.pre-commit-config.yaml:
##########
@@ -43,7 +43,17 @@ repos:
types_or: [c++]
args: [--style=file, --verbose]
exclude: ^cpp/thirdparty/
-
+
+ - repo: https://github.com/compilerla/conventional-pre-commit
+ rev: v3.0.0
+ hooks:
+ - id: conventional-pre-commit
+ stages: [ commit-msg ]
+ args: [
+ --types,feat,fix,docs,style,refactor,test,chore,perf,ci,build,revert,
Review Comment:
There is a trailing comma after "revert," which will be interpreted as an
empty string as one of the allowed types. This could allow commit messages with
an empty type (e.g., ": some message") to pass validation. Remove the trailing
comma to ensure only the explicitly defined types are allowed.
```suggestion
--types,feat,fix,docs,style,refactor,test,chore,perf,ci,build,revert
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
