Sober7135 commented on PR #857: URL: https://github.com/apache/incubator-graphar/pull/857#issuecomment-3901650901
Nice work! A couple of suggestions: 1. We could use the `pkg-config` crate instead of invoking `process::Command` directly: https://crates.io/crates/pkg-config 2. We should try `env::var("ARROW_LIB_DIR")` first. If it’s not set, then fall back to `pkg-config`. That seems more reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
