Sober7135 commented on issue #865: URL: https://github.com/apache/incubator-graphar/issues/865#issuecomment-3957400508
> Here is what i am thinking > > in [#809](https://github.com/apache/incubator-graphar/issues/809) we used `int_32` at some places replacing the platform dependent sizes So i think having same types everywhere is good thing to have, this will work as some APIs use -1 as the sentinel value. > > what are your thoughts ? even if admin is on vacation we can discuss about what to do i guess Sorry for the late reply. First, this issue is different from #809, which only explicitly specifies the underlying types for enums. So I don’t think we need to enforce the same type everywhere. And: * I think sentinel values are not a good design, to be honest — we have more modern options like `std::optional`. * Semantically, `size_t` is clearly the best choice, since the C++ standard library uses it for indexing and count/length. So yes, I’m personally quite radical on this: IMO, we should use `size_t` — or at least move toward `size_t` eventually. If you agree with this direction, then we should discuss how to handle the API breakage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
