SYaoJun commented on code in PR #861:
URL: https://github.com/apache/incubator-graphar/pull/861#discussion_r2870539337
##########
cpp/src/graphar/arrow/chunk_reader.h:
##########
@@ -267,6 +268,7 @@ class VertexPropertyArrowChunkReader {
IdType vertex_num_;
std::shared_ptr<arrow::Schema> schema_;
std::shared_ptr<arrow::Table> chunk_table_;
+ LRUCache<IdType, std::shared_ptr<arrow::Table>> chunk_cache_{4};
Review Comment:
> chunk_cache **size** can judge based on memory or let the user control it
will be better?
Actually, I don't know which place is suitable for keep this
parameters(`size`). Do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
