Sober7135 commented on code in PR #896:
URL: https://github.com/apache/incubator-graphar/pull/896#discussion_r2871164740
##########
.github/workflows/ci.yml:
##########
@@ -27,6 +27,11 @@ on:
- 'cpp/**'
- '.github/workflows/ci.yml'
pull_request:
+ types:
+ - opened
+ - synchronize
+ - reopened
+ - ready_for_review
Review Comment:
See [GitHub
docs](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request:~:text=By%20default%2C%20a%20workflow%20only%20runs%20when%20a%20pull_request%20event%27s%20activity%20type%20is%20opened%2C%20synchronize%2C%20or%20reopened.):
> By default, a workflow only runs when a `pull_request` event's activity
type is `opened`, `synchronize`, or `reopened`.
So when a PR is updated (for example, new commits are pushed and the head
branch is updated), CI will be triggered again by the `pull_request` event with
the `synchronize` activity type. See [GitHub
docs](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request:~:text=workflow%27s%20repository%20occurs.-,For%20example%2C%20if%20no%20activity%20types%20are%20specified%2C%20the%20workflow%20runs%20when%20a%20pull%20request%20is%20opened%20or%20reopened%20or%20when%20the%20head%20branch%20of%20the%20pull%20request%20is%20updated.,-For%20activity%20related).
Given that, I think it is fine to remove the explicit `types` filter and
rely on the defaults, unless we specifically want to also trigger CI on
`ready_for_review`.
CC @yangxk1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
