amrSherif12 commented on PR #930: URL: https://github.com/apache/incubator-graphar/pull/930#issuecomment-4572748571
Hello @SYaoJun, I made a new pull request because I pushed the code in a wrong branch and things got really messy and I couldn't fix it so I made a new PR. Really sorry for the inconvenience but I did all the changes you asked for This was your [https://github.com/apache/incubator-graphar/pull/928#pullrequestreview-4359286076](previous review) for my code. You suggested me to use a vector or a map for `std::map<IdType, std::vector<Edge>> edges_;` and I picked map because a vector would force me to go around the code base changing stuff because it's used in multiple places and vector has different methods that map so map fixed that as its very similar to unordered_map. I also made a round trip test as you asked but I only tested string and int I couldn't test double as I noticed that I can't add properties that are not in the schema of the test YAML so I had to use the ones already there which were string and int. I hope that was good enough and if there is another issue with my work ill fix it right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
