Copilot commented on code in PR #940:
URL: https://github.com/apache/incubator-graphar/pull/940#discussion_r3636293191
##########
cpp/benchmarks/benchmark_util.h:
##########
@@ -46,10 +46,19 @@ class BenchmarkFixture : public ::benchmark::Fixture {
}
path_ = std::string(c_root) + "/ldbc_sample/parquet/ldbc_sample.graph.yml";
auto maybe_graph_info = GraphInfo::Load(path_);
+ if (!maybe_graph_info.status().ok()) {
+ throw std::runtime_error("Failed to load graph info from " + path_ +
+ ": " + maybe_graph_info.status().message());
+ }
Review Comment:
SetUp() uses std::getenv and std::runtime_error, but this header doesn’t
include the standard headers that declare them (<cstdlib> and <stdexcept>).
Relying on transitive includes from benchmark/graphar headers can make builds
fragile if upstream includes change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
