keksmd opened a new pull request, #952: URL: https://github.com/apache/incubator-graphar/pull/952
### Reason for this PR Fixes #945. The published `ghcr.io/apache/graphar-dev:latest` image packages Arrow, Dataset, Acero, and Parquet 17.0.0, while the current C++ code unconditionally calls newer compute APIs and tests call the newer Parquet reader API. The C++ build therefore fails before it can act as the compatibility oracle for GraphAr metadata. ### What changes are included in this PR? - Restore Arrow-version guards around compute initialization, retaining the Arrow 21+ execution path. - Keep Arrow 17 dataset initialization valid and use its output-parameter Parquet `ReadTable` API. - Make C++ test Parquet reads version-aware. - Avoid cancelling a fully drained Arrow 17 Acero plan during normal completion. ### Are these changes tested? Yes, in `ghcr.io/apache/graphar-dev:latest` on Linux arm64: - `cmake --build /build --target graphar-cpplint` - CMake Debug build with `BUILD_TESTS=ON`, `BUILD_EXAMPLES=OFF`, `BUILD_BENCHMARKS=OFF`, and sanitizers disabled - `GAR_TEST_DATA=/workspace/incubator-graphar/testing ctest --test-dir /build --output-on-failure` — 20 tests passed, 0 failed. ### Are there any user-facing changes? No public GraphAr API or format semantics change. This restores the supported C++ build/test path in the published devcontainer. ## Checklist - [x] I have performed a self-review of my own code. - [x] I have formatted my own code using `make cpplint` before submitting when changed files are in the `cpp` directory. - [ ] I have performed `pre-commit run` before commit the changed files. The command is not installed on the host or the declared devcontainer. - [x] I have added tests to prove my changes are effective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
