ZekiLiu commented on PR #941:
URL:
https://github.com/apache/incubator-graphar/pull/941#issuecomment-5565024696
@keksmd , thanks for the detailed review. I pushed a commit that addresses
the feedback:
1. Unsupported versions (e.g. gar/v2) are now rejected by
ParseInfoVersion, Validate, and NewInfoVersion, so they fail at the metadata
boundary instead of surfacing later as "unsupported property types".
2. Parsing is now aligned with the C++/Java behavior: leading whitespace
is rejected, and the type list is only parsed when '(' directly follows the
version number (with spaces allowed in between). The doc
comment was updated to match the actual behavior.
3. The FileTypeJSON doc comment no longer references PropertyGroup.
4. NewInfoVersion now returns an error instead of silently clamping
non-positive versions, as you suggested.
Would you mind taking another look when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
