keksmd commented on issue #964: URL: https://github.com/apache/incubator-graphar/issues/964#issuecomment-5584285307
Status and the exact gate on this slice. The module is ready in migrated form — no \`Row\` and no \`.row(...)\` anywhere in it; batches are \`ValueVector\` / \`VectorRecordBatch\`, and \`ParquetRow\` is replaced by \`ParquetValueVector\`. I verified it compiles and tests clean against `main` plus the read contract from #972: ``` graphar-io-parquet ................................. SUCCESS ParquetPhysicalReaderFixtureTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 ParquetPhysicalWriterOffsetIndexTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 ParquetPhysicalIoEfficiencyTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 ParquetListRoundTripTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 ``` It cannot be opened as a PR against `main` today, and the reason is a real dependency, not polish: the reader side uses `PhysicalReader`, `ReadRequest`, `ReadResult`, `ReadReport`, `Projection`, `RowRange`, `Filter`, `Literal` and `ComparisonOperator`, and none of those exist on `main` yet — they are #971 and #972. Basing this PR on an unmerged branch would make a dependent chain, so I would rather wait: once #971 and #972 land, this goes up as a standalone PR cut from `main` the same day. Ordering for the remaining Java SDK slices, so nobody has to reconstruct it from the PR queue: ``` core #967 -> PR #968 (open, mergeable, CI green) io-api reads #971, #972 (open, mergeable, CI green) io-parquet #964 (ready; gated on #971 and #972) writer #973 (needs core + a format backend) validator #974 (needs core + backend + writer) ``` @SemyonSinchenko @SYaoJun review bandwidth on #971 and #972 would unblock the format backend, which is the layer that makes the storage work merged so far actually readable end to end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
