keksmd commented on PR #968: URL: https://github.com/apache/incubator-graphar/pull/968#issuecomment-5584287605
Rebased on `main` after #966 merged — the only conflict was the module list in `maven-projects/pom.xml`, where `storage-s3` and `core` were added at the same line; both are kept. I also pushed the answer to the CI question I raised earlier, rather than leaving it open: the workflow already watches `maven-projects/core/**` in its path filters, so a change here triggers the job, but `SDK_MODULES` left `core` out and the reactor never compiled or tested it — a green run proved nothing about this module. `SDK_MODULES` is now `storage-api,storage-local,io-api,storage-s3,core`. The fixture-backed test skips itself when the canonical `testing` dataset is absent, so the job stays green without the submodule and gains real coverage when it is present. Local verification against `main` with the fixtures available: ``` ChunkRangeTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 OrderedAdjacencyResolverFixtureTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 BUILD SUCCESS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
