featherchen commented on code in PR #3879:
URL: https://github.com/apache/gravitino/pull/3879#discussion_r1663101659
##########
server/src/test/java/com/datastrato/gravitino/server/web/rest/TestMetalakeOperations.java:
##########
@@ -178,6 +183,19 @@ public void testCreateMetalake() {
Assertions.assertEquals(ErrorConstants.ILLEGAL_ARGUMENTS_CODE,
errorResponse.getCode());
Assertions.assertEquals(
IllegalArgumentException.class.getSimpleName(),
errorResponse.getType());
+
+ String req2 =
"{\"names\":\"metalake\",\"comment\":\"comment\",\"properties\":{}}";
Review Comment:
Another example is `InputCoercionException`, which is support since jackson
`2.10`, these kind of exception is generated when "failed attempts to convert
specific Java value out of valid but incompatible input value", e.g. int too
large. (Ref:
https://fasterxml.github.io/jackson-core/javadoc/2.10/com/fasterxml/jackson/core/exc/InputCoercionException.html)
This kind of exception seems also hard to create in metalake sinario.
##########
server/src/test/java/com/datastrato/gravitino/server/web/rest/TestMetalakeOperations.java:
##########
@@ -178,6 +183,19 @@ public void testCreateMetalake() {
Assertions.assertEquals(ErrorConstants.ILLEGAL_ARGUMENTS_CODE,
errorResponse.getCode());
Assertions.assertEquals(
IllegalArgumentException.class.getSimpleName(),
errorResponse.getType());
+
+ String req2 =
"{\"names\":\"metalake\",\"comment\":\"comment\",\"properties\":{}}";
Review Comment:
Another example is `InputCoercionException`, which is support since jackson
`2.10`, this kind of exception is generated when "failed attempts to convert
specific Java value out of valid but incompatible input value", e.g. int too
large. (Ref:
https://fasterxml.github.io/jackson-core/javadoc/2.10/com/fasterxml/jackson/core/exc/InputCoercionException.html)
This kind of exception seems also hard to create in metalake sinario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
