noidname01 commented on code in PR #4011:
URL: https://github.com/apache/gravitino/pull/4011#discussion_r1663573099


##########
clients/client-python/gravitino/utils/http_client.py:
##########
@@ -124,23 +124,38 @@ def _make_request(self, opener, request, timeout=None):
             raise exc from None
 
     def _request(
-        self, method, endpoint, params=None, json=None, headers=None, 
timeout=None
+        self,
+        method,
+        endpoint,
+        params=None,
+        json=None,
+        data=None,
+        headers=None,
+        timeout=None,
     ):
         method = method.upper()
         request_data = None
 
         if headers:
             self._update_headers(headers)
+
+        if data:
+            request_data = urlencode(data.to_dict()).encode()
+            headers = {
+                "Content-Type": "application/x-www-form-urlencoded",

Review Comment:
   Added as static variables of `HTTPClient`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to