lw-yang commented on code in PR #4055:
URL: https://github.com/apache/gravitino/pull/4055#discussion_r1663829135
##########
core/src/main/java/com/datastrato/gravitino/authorization/AccessControlManager.java:
##########
@@ -101,6 +101,14 @@ public User getUser(String metalake, String user)
return doWithNonAdminLock(() -> userGroupManager.getUser(metalake, user));
}
+ public String[] listUsers(String metalake) throws NoSuchMetalakeException {
+ return doWithNonAdminLock(() -> userGroupManager.listUsers(metalake));
+ }
+
+ public User[] listUsersInfo(String metalake) throws NoSuchMetalakeException {
+ return doWithNonAdminLock(() -> userGroupManager.listUsersInfo(metalake));
+ }
Review Comment:
I think `listUsers` -> `listUserNames`, `listUsersInfo` -> `listUsers`
would be more appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
