yuqi1129 commented on PR #3742:
URL: https://github.com/apache/gravitino/pull/3742#issuecomment-2207984826
@shaofengshi
Can you also modify the Java doc regarding interface changes? for example
```java
/**
* Create a fileset metadata in the catalog.
*
* <p>If the type of the fileset object is "MANAGED", the underlying
storageLocation can be null,
* and Gravitino will manage the storage location based on the location of
the schema.
*
* <p>If the type of the fileset object is "EXTERNAL", the underlying
storageLocation must be set.
*
* @param ident A fileset identifier.
* @param comment The comment of the fileset.
* @param type The type of the fileset.
* @param storageLocation The storage location of the fileset.
* @param properties The properties of the fileset.
* @return The created fileset metadata
* @throws NoSuchSchemaException If the schema does not exist.
* @throws FilesetAlreadyExistsException If the fileset already exists.
*/
Fileset createFileset(
NameIdentifier ident,
String comment,
Fileset.Type type,
String storageLocation,
Map<String, String> properties)
throws NoSuchSchemaException, FilesetAlreadyExistsException;
```
The `ident` in method `createFileset` is different from before(before:
{metalakeName}.{catalogName}.{schemaName}.{filesetName},
after:{schemaName}.{filesetName}) , the sentence "A fileset identifier" is very
vague.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
