ian910297 commented on issue #3767: URL: https://github.com/apache/gravitino/issues/3767#issuecomment-2209654750
Hi @noidname01 1. exception I agree that we should prioritize resolving issue [https://github.com/apache/gravitino/issues/4012](https://github.com/apache/gravitino/issues/4012). 2. unit test Pylint flags the following structure as duplicate code but fixed values expected in unit test. ``` AuditDTO( _creator="test", _create_time="2022-01-01T00:00:00Z", _last_modifier="test", _last_modified_time="2024-04-05T10:10:35.218Z", ) ``` I've considered two solutions: * (Simpler) Disable duplicated code detection for specific file / directory. * (More complex) Use factory / builder design pattern to create object for test. Considering the potential increase in tests, it's crucial to evaluate the scalability and reusability of the chosen approach. 3. pythonic code I agree that we should create a separate subtask for this, similar to case 1. In summary, I believe addressing the duplicated code linting issue is not a priority at this stage. We should focus on reviewing the errors to identify potential architectural improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
