xunliu commented on code in PR #3946: URL: https://github.com/apache/gravitino/pull/3946#discussion_r1668850652
########## core/src/main/java/com/datastrato/gravitino/connector/authorization/RoleAuthorizationPlugin.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package com.datastrato.gravitino.connector.authorization; + +import com.datastrato.gravitino.authorization.Role; +import com.datastrato.gravitino.authorization.RoleChange; +import com.datastrato.gravitino.authorization.SecurableObject; +import java.util.List; + +/** Interface for authorization Role plugin operation of the underlying access control system */ +interface RoleAuthorizationPlugin { + /** + * Creates a new Role into the underlying access control system. + * + * @param role The entity of the Role. + * @param securableObjects The securable objects of the Role. + * @return True if the create operation success; False if the create operation failed. + * @throws RuntimeException If creating the Role encounters storage issues. + */ + Boolean onCreateRole(Role role, List<SecurableObject> securableObjects) throws RuntimeException; Review Comment: DONE ########## core/src/main/java/com/datastrato/gravitino/connector/BaseCatalog.java: ########## @@ -57,6 +65,13 @@ public abstract class BaseCatalog<T extends BaseCatalog> // The object you used is not stable, don't use it unless you know what you are doing. @VisibleForTesting public static final String CATALOG_OPERATION_IMPL = "ops-impl"; + // Different catalogs may have different authorization implementations, this variable is used as a + // key in properties of catalogs to inject custom authorization to Gravitino. + public static final String AUTHORIZATION_IMPL = "authorization-impl"; Review Comment: DONE. ########## core/src/main/java/com/datastrato/gravitino/connector/authorization/RoleAuthorizationPlugin.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package com.datastrato.gravitino.connector.authorization; + +import com.datastrato.gravitino.authorization.Role; +import com.datastrato.gravitino.authorization.RoleChange; +import com.datastrato.gravitino.authorization.SecurableObject; +import java.util.List; + +/** Interface for authorization Role plugin operation of the underlying access control system */ +interface RoleAuthorizationPlugin { + /** + * Creates a new Role into the underlying access control system. Review Comment: Add some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
