jerqi commented on code in PR #3852: URL: https://github.com/apache/gravitino/pull/3852#discussion_r1672117933
########## catalogs/catalog-hadoop/src/main/java/com/datastrato/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ########## @@ -96,6 +99,14 @@ public class HadoopCatalogOperations implements CatalogOperations, SupportsSchem private CatalogInfo catalogInfo; + private final List<Closeable> closeables = Lists.newArrayList(); + + private final Map<NameIdentifier, UserInfo> userInfoMap = Maps.newConcurrentMap(); + + public static final String GRAVITINO_KEYTAB_FORMAT = "keytabs/gravitino-%s"; + + private final ThreadLocal<String> currentUser = ThreadLocal.withInitial(() -> null); Review Comment: Could you avoid using thread local variable here? We can doAs in the wrapper like other code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
