yuqi1129 commented on code in PR #4122:
URL: https://github.com/apache/gravitino/pull/4122#discussion_r1673834028
##########
catalogs/bundled-catalog/src/main/java/com/datastrato/gravitino/catalog/property/PropertyConverter.java:
##########
@@ -81,30 +72,14 @@ public Map<String, Object>
engineToGravitinoProperties(Map<String, Object> engin
Map<String, Object> gravitinoProperties = new HashMap<>();
Map<String, String> engineToGravitinoMapping = engineToGravitinoMapping();
- Map<String, PropertyEntry<?>> propertyEntryMap = gravitinoPropertyMeta();
for (Map.Entry<String, Object> entry : engineProperties.entrySet()) {
String gravitinoKey = engineToGravitinoMapping.get(entry.getKey());
if (gravitinoKey != null) {
- PropertyEntry<?> propertyEntry = propertyEntryMap.get(gravitinoKey);
Review Comment:
I think the reason you gave is not very persuasive `seems not to have much
usage, it use PropertyEntry to decode to an object, it will be transformed to
string.`
We use `propertyEntry.decode` to check whether the property value passed to
the engine is valid or not, so why do you think it's not very helpful here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
