yuqi1129 commented on code in PR #4108:
URL: https://github.com/apache/gravitino/pull/4108#discussion_r1675242336
##########
catalogs/catalog-kafka/src/main/java/com/datastrato/gravitino/catalog/kafka/KafkaCatalogOperations.java:
##########
@@ -181,6 +184,21 @@ public NameIdentifier[] listTopics(Namespace namespace)
throws NoSuchSchemaExcep
}
}
+ @Override
+ public void testConnection(
+ NameIdentifier catalogIdent,
+ Catalog.Type type,
+ String provider,
+ String comment,
+ Map<String, String> properties) {
+ try {
+ adminClient.listTopics().names().get();
Review Comment:
Why do you use an already-created `adminClient` to test Connection since you
intend to test connection with the parameter?
##########
api/src/main/java/com/datastrato/gravitino/SupportsCatalogs.java:
##########
@@ -114,4 +114,23 @@ Catalog alterCatalog(String catalogName, CatalogChange...
changes)
* @return True if the catalog was dropped, false otherwise.
*/
boolean dropCatalog(String catalogName);
+
+ /**
+ * Test whether a catalog can be created successfully with the specified
parameters, without
Review Comment:
I believe, this should be 'Test whether we can **connect** to catalog
engine(or something similar) with specified parameters'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
