jerryshao commented on code in PR #4109: URL: https://github.com/apache/gravitino/pull/4109#discussion_r1675394470
########## core/src/main/java/com/datastrato/gravitino/SupportsExtraOperations.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package com.datastrato.gravitino; + +import com.datastrato.gravitino.exceptions.NoSuchEntityException; +import com.datastrato.gravitino.meta.TagEntity; +import java.io.IOException; + +/** + * An interface to support extra entity store operations, this interface should be mixed with {@link + * EntityStore} to provide extra operations. + * + * <p>Any operations that can be done by the entity store should be added here. + */ +public interface SupportsExtraOperations { + + /** + * List all the metadata objects that are associated with the given tag. + * + * @param tagIdent The identifier of the tag. + * @return The list of metadata objects associated with the given tag. + */ + MetadataObject[] listAssociatedMetadataObjectsForTag(NameIdentifier tagIdent) throws IOException; Review Comment: I cannot figure out a better solution to refactor the `EntityStore`, if you have better solutions I think you can refactor this code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
