yuqi1129 commented on code in PR #3943: URL: https://github.com/apache/gravitino/pull/3943#discussion_r1681987390
########## server/src/main/java/org/apache/gravitino/server/web/rest/TagOperations.java: ########## @@ -0,0 +1,467 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.server.web.rest; + +import com.codahale.metrics.annotation.ResponseMetered; +import com.codahale.metrics.annotation.Timed; +import com.google.common.collect.Lists; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Locale; +import java.util.Optional; +import javax.inject.Inject; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.Response; +import org.apache.commons.lang3.ArrayUtils; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.MetadataObjects; +import org.apache.gravitino.dto.requests.TagCreateRequest; +import org.apache.gravitino.dto.requests.TagUpdateRequest; +import org.apache.gravitino.dto.requests.TagUpdatesRequest; +import org.apache.gravitino.dto.requests.TagsAssociateRequest; +import org.apache.gravitino.dto.responses.DropResponse; +import org.apache.gravitino.dto.responses.MetadataObjectListResponse; +import org.apache.gravitino.dto.responses.NameListResponse; +import org.apache.gravitino.dto.responses.TagListResponse; +import org.apache.gravitino.dto.responses.TagResponse; +import org.apache.gravitino.dto.tag.MetadataObjectDTO; +import org.apache.gravitino.dto.tag.TagDTO; +import org.apache.gravitino.dto.util.DTOConverters; +import org.apache.gravitino.exceptions.NoSuchTagException; +import org.apache.gravitino.metrics.MetricNames; +import org.apache.gravitino.server.web.Utils; +import org.apache.gravitino.tag.Tag; +import org.apache.gravitino.tag.TagChange; +import org.apache.gravitino.tag.TagManager; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Path("metalakes/{metalake}/tags") +public class TagOperations { + + private static final Logger LOG = LoggerFactory.getLogger(TagOperations.class); + + private final TagManager tagManager; + + @Context private HttpServletRequest httpRequest; + + @Inject + public TagOperations(TagManager tagManager) { + this.tagManager = tagManager; + } + + @GET + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "list-tags." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "list-tags", absolute = true) + public Response listTags( + @PathParam("metalake") String metalake, + @QueryParam("details") @DefaultValue("false") boolean verbose) { + LOG.info( + "Received list tag {} request for metalake: {}", verbose ? "infos" : "names", metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + if (verbose) { + Tag[] tags = tagManager.listTagsInfo(metalake); + TagDTO[] tagDTOs; + if (ArrayUtils.isEmpty(tags)) { + tagDTOs = new TagDTO[0]; + } else { + tagDTOs = + Arrays.stream(tags) + .map(t -> DTOConverters.toDTO(t, Optional.empty())) + .toArray(TagDTO[]::new); + } + + LOG.info("List {} tags info under metalake: {}", tagDTOs.length, metalake); + return Utils.ok(new TagListResponse(tagDTOs)); + + } else { + String[] tagNames = tagManager.listTags(metalake); + tagNames = tagNames == null ? new String[0] : tagNames; + + LOG.info("List {} tags under metalake: {}", tagNames.length, metalake); + return Utils.ok(new NameListResponse(tagNames)); + } + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.LIST, "", metalake, e); + } + } + + @POST + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "create-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "create-tag", absolute = true) + public Response createTag(@PathParam("metalake") String metalake, TagCreateRequest request) { + LOG.info("Received create tag request under metalake: {}", metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + request.validate(); + Tag tag = + tagManager.createTag( + metalake, request.getName(), request.getComment(), request.getProperties()); + + LOG.info("Created tag: {} under metalake: {}", tag.name(), metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException( + OperationType.CREATE, request.getName(), metalake, e); + } + } + + @GET + @Path("{tag}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "get-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "get-tag", absolute = true) + public Response getTag(@PathParam("metalake") String metalake, @PathParam("tag") String name) { + LOG.info("Received get tag request for tag: {} under metalake: {}", name, metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + Tag tag = tagManager.getTag(metalake, name); + LOG.info("Get tag: {} under metalake: {}", name, metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.GET, name, metalake, e); + } + } + + @POST + @Path("{tag}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "alter-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "alter-tag", absolute = true) + public Response alterTag( + @PathParam("metalake") String metalake, + @PathParam("tag") String name, + TagUpdatesRequest request) { + LOG.info("Received alter tag request for tag: {} under metalake: {}", name, metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + request.validate(); + + TagChange[] changes = + request.getUpdates().stream() + .map(TagUpdateRequest::tagChange) + .toArray(TagChange[]::new); + Tag tag = tagManager.alterTag(metalake, name, changes); + + LOG.info("Altered tag: {} under metalake: {}", name, metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.ALTER, name, metalake, e); + } + } + + @DELETE + @Path("{tag}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "delete-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "delete-tag", absolute = true) + public Response deleteTag(@PathParam("metalake") String metalake, @PathParam("tag") String name) { + LOG.info("Received delete tag request for tag: {} under metalake: {}", name, metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + boolean deleted = tagManager.deleteTag(metalake, name); + if (!deleted) { + LOG.warn("Failed to delete tag {} under metalake {}", name, metalake); + } else { + LOG.info("Deleted tag: {} under metalake: {}", name, metalake); + } + + return Utils.ok(new DropResponse(deleted)); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.DELETE, name, metalake, e); + } + } + + @GET + @Path("{type}/{fullName}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "list-object-tags." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "list-object-tags", absolute = true) + public Response listTagsForMetdataObject( Review Comment: Metdata -> Metadata ########## clients/client-java/src/main/java/org/apache/gravitino/client/ObjectMapperProvider.java: ########## @@ -39,7 +40,8 @@ private static class ObjectMapperHolder { .enable(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS) .disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES) .build() - .registerModule(new JavaTimeModule()); + .registerModule(new JavaTimeModule()) + .registerModule(new Jdk8Module()); Review Comment: What does the module do? ########## common/src/main/java/org/apache/gravitino/dto/responses/MetadataObjectListResponse.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.dto.responses; + +import com.fasterxml.jackson.annotation.JsonProperty; +import com.google.common.base.Preconditions; +import java.util.Arrays; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.ToString; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.dto.tag.MetadataObjectDTO; + +/** Represents a response containing a list of metadata objects. */ +@Getter +@EqualsAndHashCode(callSuper = true) +@ToString +public class MetadataObjectListResponse extends BaseResponse { + + @JsonProperty("metadataObjects") + private final MetadataObjectDTO[] metadataObjects; + + /** + * Constructor for MetadataObjectListResponse. + * + * @param metadataObjects The array of metadata object DTOs. + */ + public MetadataObjectListResponse(MetadataObjectDTO[] metadataObjects) { + super(0); + this.metadataObjects = metadataObjects; + } + + /** Default constructor for MetadataObjectListResponse. (Used for Jackson deserialization.) */ + public MetadataObjectListResponse() { + super(); + this.metadataObjects = null; + } + + /** + * Validates the response data. + * + * @throws IllegalArgumentException if name or audit information is not set. + */ + public void validate() throws IllegalArgumentException { + super.validate(); + + Preconditions.checkArgument(metadataObjects != null, "metadataObjects must be non-null"); + Arrays.stream(metadataObjects) + .forEach( + object -> + Preconditions.checkArgument( + object != null && StringUtils.isNoneBlank(object.name()), + "metadataObject must not be null and empty")); Review Comment: null or empty? ########## server/src/main/java/org/apache/gravitino/server/web/rest/TagOperations.java: ########## @@ -0,0 +1,467 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.server.web.rest; + +import com.codahale.metrics.annotation.ResponseMetered; +import com.codahale.metrics.annotation.Timed; +import com.google.common.collect.Lists; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Locale; +import java.util.Optional; +import javax.inject.Inject; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.Response; +import org.apache.commons.lang3.ArrayUtils; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.MetadataObjects; +import org.apache.gravitino.dto.requests.TagCreateRequest; +import org.apache.gravitino.dto.requests.TagUpdateRequest; +import org.apache.gravitino.dto.requests.TagUpdatesRequest; +import org.apache.gravitino.dto.requests.TagsAssociateRequest; +import org.apache.gravitino.dto.responses.DropResponse; +import org.apache.gravitino.dto.responses.MetadataObjectListResponse; +import org.apache.gravitino.dto.responses.NameListResponse; +import org.apache.gravitino.dto.responses.TagListResponse; +import org.apache.gravitino.dto.responses.TagResponse; +import org.apache.gravitino.dto.tag.MetadataObjectDTO; +import org.apache.gravitino.dto.tag.TagDTO; +import org.apache.gravitino.dto.util.DTOConverters; +import org.apache.gravitino.exceptions.NoSuchTagException; +import org.apache.gravitino.metrics.MetricNames; +import org.apache.gravitino.server.web.Utils; +import org.apache.gravitino.tag.Tag; +import org.apache.gravitino.tag.TagChange; +import org.apache.gravitino.tag.TagManager; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Path("metalakes/{metalake}/tags") +public class TagOperations { + + private static final Logger LOG = LoggerFactory.getLogger(TagOperations.class); + + private final TagManager tagManager; + + @Context private HttpServletRequest httpRequest; + + @Inject + public TagOperations(TagManager tagManager) { + this.tagManager = tagManager; + } + + @GET + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "list-tags." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "list-tags", absolute = true) + public Response listTags( + @PathParam("metalake") String metalake, + @QueryParam("details") @DefaultValue("false") boolean verbose) { + LOG.info( + "Received list tag {} request for metalake: {}", verbose ? "infos" : "names", metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + if (verbose) { + Tag[] tags = tagManager.listTagsInfo(metalake); + TagDTO[] tagDTOs; + if (ArrayUtils.isEmpty(tags)) { + tagDTOs = new TagDTO[0]; + } else { + tagDTOs = + Arrays.stream(tags) + .map(t -> DTOConverters.toDTO(t, Optional.empty())) + .toArray(TagDTO[]::new); + } + + LOG.info("List {} tags info under metalake: {}", tagDTOs.length, metalake); + return Utils.ok(new TagListResponse(tagDTOs)); + + } else { + String[] tagNames = tagManager.listTags(metalake); + tagNames = tagNames == null ? new String[0] : tagNames; + + LOG.info("List {} tags under metalake: {}", tagNames.length, metalake); + return Utils.ok(new NameListResponse(tagNames)); + } + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.LIST, "", metalake, e); + } + } + + @POST + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "create-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "create-tag", absolute = true) + public Response createTag(@PathParam("metalake") String metalake, TagCreateRequest request) { + LOG.info("Received create tag request under metalake: {}", metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + request.validate(); + Tag tag = + tagManager.createTag( + metalake, request.getName(), request.getComment(), request.getProperties()); + + LOG.info("Created tag: {} under metalake: {}", tag.name(), metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException( + OperationType.CREATE, request.getName(), metalake, e); + } + } + + @GET + @Path("{tag}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "get-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "get-tag", absolute = true) + public Response getTag(@PathParam("metalake") String metalake, @PathParam("tag") String name) { + LOG.info("Received get tag request for tag: {} under metalake: {}", name, metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + Tag tag = tagManager.getTag(metalake, name); + LOG.info("Get tag: {} under metalake: {}", name, metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.GET, name, metalake, e); + } + } + + @POST Review Comment: Why do we still use `POST` to alter operations? I noticed that `PUT` was used for other entities. ########## server/src/main/java/org/apache/gravitino/server/web/rest/TagOperations.java: ########## @@ -0,0 +1,467 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.server.web.rest; + +import com.codahale.metrics.annotation.ResponseMetered; +import com.codahale.metrics.annotation.Timed; +import com.google.common.collect.Lists; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Locale; +import java.util.Optional; +import javax.inject.Inject; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.Response; +import org.apache.commons.lang3.ArrayUtils; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.MetadataObjects; +import org.apache.gravitino.dto.requests.TagCreateRequest; +import org.apache.gravitino.dto.requests.TagUpdateRequest; +import org.apache.gravitino.dto.requests.TagUpdatesRequest; +import org.apache.gravitino.dto.requests.TagsAssociateRequest; +import org.apache.gravitino.dto.responses.DropResponse; +import org.apache.gravitino.dto.responses.MetadataObjectListResponse; +import org.apache.gravitino.dto.responses.NameListResponse; +import org.apache.gravitino.dto.responses.TagListResponse; +import org.apache.gravitino.dto.responses.TagResponse; +import org.apache.gravitino.dto.tag.MetadataObjectDTO; +import org.apache.gravitino.dto.tag.TagDTO; +import org.apache.gravitino.dto.util.DTOConverters; +import org.apache.gravitino.exceptions.NoSuchTagException; +import org.apache.gravitino.metrics.MetricNames; +import org.apache.gravitino.server.web.Utils; +import org.apache.gravitino.tag.Tag; +import org.apache.gravitino.tag.TagChange; +import org.apache.gravitino.tag.TagManager; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Path("metalakes/{metalake}/tags") +public class TagOperations { + + private static final Logger LOG = LoggerFactory.getLogger(TagOperations.class); + + private final TagManager tagManager; + + @Context private HttpServletRequest httpRequest; + + @Inject + public TagOperations(TagManager tagManager) { + this.tagManager = tagManager; + } + + @GET + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "list-tags." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "list-tags", absolute = true) + public Response listTags( + @PathParam("metalake") String metalake, + @QueryParam("details") @DefaultValue("false") boolean verbose) { + LOG.info( + "Received list tag {} request for metalake: {}", verbose ? "infos" : "names", metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + if (verbose) { + Tag[] tags = tagManager.listTagsInfo(metalake); + TagDTO[] tagDTOs; + if (ArrayUtils.isEmpty(tags)) { + tagDTOs = new TagDTO[0]; + } else { + tagDTOs = + Arrays.stream(tags) + .map(t -> DTOConverters.toDTO(t, Optional.empty())) + .toArray(TagDTO[]::new); + } + + LOG.info("List {} tags info under metalake: {}", tagDTOs.length, metalake); + return Utils.ok(new TagListResponse(tagDTOs)); + + } else { + String[] tagNames = tagManager.listTags(metalake); + tagNames = tagNames == null ? new String[0] : tagNames; + + LOG.info("List {} tags under metalake: {}", tagNames.length, metalake); + return Utils.ok(new NameListResponse(tagNames)); + } + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.LIST, "", metalake, e); + } + } + + @POST + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "create-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "create-tag", absolute = true) + public Response createTag(@PathParam("metalake") String metalake, TagCreateRequest request) { + LOG.info("Received create tag request under metalake: {}", metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + request.validate(); + Tag tag = + tagManager.createTag( + metalake, request.getName(), request.getComment(), request.getProperties()); + + LOG.info("Created tag: {} under metalake: {}", tag.name(), metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException( + OperationType.CREATE, request.getName(), metalake, e); + } + } + + @GET + @Path("{tag}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "get-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "get-tag", absolute = true) + public Response getTag(@PathParam("metalake") String metalake, @PathParam("tag") String name) { + LOG.info("Received get tag request for tag: {} under metalake: {}", name, metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + Tag tag = tagManager.getTag(metalake, name); + LOG.info("Get tag: {} under metalake: {}", name, metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.GET, name, metalake, e); + } + } + + @POST + @Path("{tag}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "alter-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "alter-tag", absolute = true) + public Response alterTag( + @PathParam("metalake") String metalake, + @PathParam("tag") String name, + TagUpdatesRequest request) { + LOG.info("Received alter tag request for tag: {} under metalake: {}", name, metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + request.validate(); + + TagChange[] changes = + request.getUpdates().stream() + .map(TagUpdateRequest::tagChange) + .toArray(TagChange[]::new); + Tag tag = tagManager.alterTag(metalake, name, changes); + + LOG.info("Altered tag: {} under metalake: {}", name, metalake); + return Utils.ok(new TagResponse(DTOConverters.toDTO(tag, Optional.empty()))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.ALTER, name, metalake, e); + } + } + + @DELETE + @Path("{tag}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "delete-tag." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "delete-tag", absolute = true) + public Response deleteTag(@PathParam("metalake") String metalake, @PathParam("tag") String name) { + LOG.info("Received delete tag request for tag: {} under metalake: {}", name, metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + boolean deleted = tagManager.deleteTag(metalake, name); + if (!deleted) { + LOG.warn("Failed to delete tag {} under metalake {}", name, metalake); + } else { + LOG.info("Deleted tag: {} under metalake: {}", name, metalake); + } + + return Utils.ok(new DropResponse(deleted)); + }); + } catch (Exception e) { + return ExceptionHandlers.handleTagException(OperationType.DELETE, name, metalake, e); + } + } + + @GET + @Path("{type}/{fullName}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "list-object-tags." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "list-object-tags", absolute = true) + public Response listTagsForMetdataObject( + @PathParam("metalake") String metalake, + @PathParam("type") String type, + @PathParam("fullName") String fullName, + @QueryParam("details") @DefaultValue("false") boolean verbose) { + LOG.info( + "Received list tag {} request for object type: {}, full name: {} under metalake: {}", + verbose ? "infos" : "names", + type, + fullName, + metalake); + + try { + return Utils.doAs( + httpRequest, + () -> { + MetadataObject object = MetadataObjects.parse(fullName, toType(type)); + + if (verbose) { Review Comment: I suggest we combine the logic for getting tag information and tag name as they both need to the full tag information from underlying storage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
