jerqi commented on code in PR #4160:
URL: https://github.com/apache/gravitino/pull/4160#discussion_r1682668999


##########
server-common/src/main/java/org/apache/gravitino/server/authentication/OAuth2TokenAuthenticator.java:
##########
@@ -126,6 +126,13 @@ public void initialize(Config config) throws 
RuntimeException {
     this.defaultSigningKey = 
decodeSignKey(Base64.getDecoder().decode(configuredSignKey), algType);
   }
 
+  @Override
+  public boolean supports(byte[] tokenData) {

Review Comment:
   Could you have a better name?What does  this authenticator support?



##########
server-common/src/main/java/org/apache/gravitino/server/authentication/OAuth2TokenAuthenticator.java:
##########
@@ -126,6 +126,13 @@ public void initialize(Config config) throws 
RuntimeException {
     this.defaultSigningKey = 
decodeSignKey(Base64.getDecoder().decode(configuredSignKey), algType);
   }
 
+  @Override
+  public boolean supports(byte[] tokenData) {

Review Comment:
   Could you have a better name? What does  this authenticator support?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to