justinmclean commented on code in PR #4230:
URL: https://github.com/apache/gravitino/pull/4230#discussion_r1685830381
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/CatalogConnectorManager.java:
##########
@@ -133,8 +133,11 @@ private void loadMetalake() {
LOG.error("Load Metalake {} failed.", usedMetalake, e);
}
}
- } catch (Throwable t) {
- LOG.error("Fatal errors when loading metalake", t);
+ } catch (OutOfMemoryError outOfMemoryError) {
Review Comment:
Thanks for helping out here. There's no need to catch OutOfMemoryError or
InternalError explicitly, once that happens there's probably not much you can
do and I'm not sure the extra logging adds anything. Throwable include
Expection and Error and normally you just want to catch Exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
