justinmclean commented on code in PR #4224:
URL: https://github.com/apache/gravitino/pull/4224#discussion_r1685831289
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -194,7 +194,10 @@ public TrinoConfig() {
return;
}
- properties.load(new FileInputStream(configFileName));
+ try (FileInputStream input = new FileInputStream(configFileName)) {
+ properties.load(input);
+ }
+
Review Comment:
Thanks for helping out here. Is this code complete as it looks like the
input stream is still not closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
