This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 38fe81580 [#4182] improvement: close the input file stream (#4224)
38fe81580 is described below

commit 38fe815804fd412a4f36cf111342a74b0ab7d9cf
Author: Pravin Kumar <[email protected]>
AuthorDate: Mon Jul 22 08:53:13 2024 +0530

    [#4182] improvement: close the input file stream (#4224)
    
    ### What changes were proposed in this pull request?
    
    Added `try with resources` block for handling file input operations to 
ensure the file
    is properly closed even if an error occurs.
    
    ### Why are the changes needed?
    
    Fix: #4182
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    existing tests
    
    Signed-off-by: pravo23 <[email protected]>
    Co-authored-by: pravo23 <[email protected]>
---
 .../java/org/apache/gravitino/trino/connector/GravitinoConfig.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java
 
b/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java
index bd32af3f9..ffb70a1e8 100644
--- 
a/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java
+++ 
b/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java
@@ -194,7 +194,10 @@ public class GravitinoConfig {
           return;
         }
 
-        properties.load(new FileInputStream(configFileName));
+        try (FileInputStream input = new FileInputStream(configFileName)) {
+          properties.load(input);
+        }
+
         if (properties.containsKey(TRINO_CATALOG_STORE)
             && !properties
                 .getProperty(TRINO_CATALOG_STORE)

Reply via email to