mchades commented on code in PR #4229:
URL: https://github.com/apache/gravitino/pull/4229#discussion_r1686421136
##########
build.gradle.kts:
##########
@@ -690,8 +690,12 @@ fun printDockerCheckInfo() {
val dockerRunning = project.extra["dockerRunning"] as? Boolean ?: false
val macDockerConnector = project.extra["macDockerConnector"] as? Boolean ?:
false
val isOrbStack = project.extra["isOrbStack"] as? Boolean ?: false
-
- if (extra["skipDockerTests"].toString().toBoolean()) {
+ val skipDockerTest = if (extra["skipDockerTests"].toString().toBoolean()) {
+ System.getenv("SKIP_DOCKER_TESTS")?.toBoolean() ?: true
+ } else {
+ false
+ }
Review Comment:
Please add comments to clarify the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
