(gravitino) branch main updated: [#4187] improvement: added missing Override annotation (#4245)

[jshao]

This is an automated email from the ASF dual-hosted git repository.

jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new f26a6ab75 [#4187] improvement: added missing Override annotation 
(#4245)
f26a6ab75 is described below

commit f26a6ab750ab050335c39c9f5f782537c88b535d
Author: Pravin Kumar <kumarpravi...@gmail.com>
AuthorDate: Tue Jul 23 18:07:48 2024 +0530

    [#4187] improvement: added missing Override annotation (#4245)
    
    ### What changes were proposed in this pull request?
    added missing `@Override` annotation in subclass methods
    
    ### Why are the changes needed?
    
    Fix: #4187
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    existing test cases
    
    Signed-off-by: pravo23 <pravo23@192.168.1.6>
    Co-authored-by: pravo23 <pravo23@192.168.1.6>
---
 .../iceberg/common/authentication/kerberos/KerberosConfig.java          | 1 +
 .../apache/gravitino/spark/connector/SparkTableChangeConverter34.java   | 1 +
 .../java/org/apache/gravitino/spark/connector/SparkTypeConverter34.java | 2 ++
 3 files changed, 4 insertions(+)

diff --git 
a/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/authentication/kerberos/KerberosConfig.java
 
b/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/authentication/kerberos/KerberosConfig.java
index 34c0ad1dc..541b8b4ee 100644
--- 
a/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/authentication/kerberos/KerberosConfig.java
+++ 
b/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/authentication/kerberos/KerberosConfig.java
@@ -80,6 +80,7 @@ public class KerberosConfig extends AuthenticationConfig {
     loadFromMap(properties, k -> true);
   }
 
+  @Override
   public boolean isImpersonationEnabled() {
     return get(ENABLE_IMPERSONATION_ENTRY);
   }
diff --git 
a/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTableChangeConverter34.java
 
b/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTableChangeConverter34.java
index 3dfae62dc..9f20a0fe6 100644
--- 
a/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTableChangeConverter34.java
+++ 
b/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTableChangeConverter34.java
@@ -25,6 +25,7 @@ public class SparkTableChangeConverter34 extends 
SparkTableChangeConverter {
     super(sparkTypeConverter);
   }
 
+  @Override
   public org.apache.gravitino.rel.TableChange 
toGravitinoTableChange(TableChange change) {
     if (change instanceof TableChange.UpdateColumnDefaultValue) {
       TableChange.UpdateColumnDefaultValue updateColumnDefaultValue =
diff --git 
a/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTypeConverter34.java
 
b/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTypeConverter34.java
index 487dc4f86..0002883fd 100644
--- 
a/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTypeConverter34.java
+++ 
b/spark-connector/v3.4/spark/src/main/java/org/apache/gravitino/spark/connector/SparkTypeConverter34.java
@@ -25,6 +25,7 @@ import org.apache.spark.sql.types.TimestampNTZType;
 
 public class SparkTypeConverter34 extends SparkTypeConverter {
 
+  @Override
   public Type toGravitinoType(DataType sparkType) {
     if (sparkType instanceof TimestampNTZType) {
       return Types.TimestampType.withoutTimeZone();
@@ -33,6 +34,7 @@ public class SparkTypeConverter34 extends SparkTypeConverter {
     }
   }
 
+  @Override
   public DataType toSparkType(Type gravitinoType) {
     if (gravitinoType instanceof Types.TimestampType
         && ((Types.TimestampType) gravitinoType).hasTimeZone() == false) {